Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8200191

Verify exported symbols in java.base

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: 11, 12
    • Fix Version/s: 12
    • Component/s: core-libs
    • Labels:

      Description

      As part of JDK-8200178, I was asked to file a bug detailing all "suspicious" code I found related to exported symbols. Here is the list for java.base. Note that "suspicious" might just be something I misunderstood, not a definite cause for action.

      In libjava:
       * throwFileNotFoundException, getLastErrorString, getErrorString should probably not be exported.
       * winFileHandleOpen, handleLseek was flagged during review as suspicious.
       * Java_java_io_FileOutputStream_close0() in FileOutputStream_md.c is probably unused.

      In libnet:
       * NET_Wait was flagged during review as suspicious. Should it really be exported?
       * Multiple methods are named like exported symbols, but are not actually exported. Is this correct? The symbols are:
         NET_GetError, NET_ThrowCurrent, NET_GetFileDescriptorID, NET_IsIPv4Mapped, NET_IPv4MappedToIPv4, NET_IsEqual, NET_IsZeroAddr.

      In libnio:
       * handleSocketError should most likely not be exported.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                prappo Pavel Rappo
                Reporter:
                ihse Magnus Ihse Bursie
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: