Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8201317

X25519/X448 code improvements

    XMLWordPrintable

    Details

      Backports

        Description

        The following suggestions were made late in the X25519/X448 code development cycle, and the changes did not make it in time for code review:

        1) Ensure that the contract for methods that take array arguments is properly specified and/or checked. For example IntegerPolynomial::addLimbs/conditionalSwap take two arrays, but it is not stated/checked that these arrays must have the same length.

        2) In XDHKeyAgreement::engineGenerateSecret, use secure coding guidelines style to prevent overflow. Change:

         if (offset + secretLen > sharedSecret.length) ...
         to
         if (secretLen > sharedSecret.length - offset) ...

        Or perhaps Math.addExact can be used here.

          Attachments

            Issue Links

              Activity

                People

                • Assignee:
                  apetcher Adam Petcher (Inactive)
                  Reporter:
                  apetcher Adam Petcher (Inactive)
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  4 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: