Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8205407

[windows, vs<2017] C4800 after 8203197

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: 11
    • Fix Version/s: 11
    • Component/s: infrastructure
    • Labels:
      None
    • Subcomponent:
    • Resolved In Build:
      b19

      Backports

        Description


        JDK-8203197 broke the windows build for Visual Studio versions < 2017, since it causes warnings C4800 to pop up at the places where in loopnode.hpp a flag is set or examined in _loopflag:

        e:\priv\openjdk\repos\jdk\src\hotspot\share\opto/loopnode.hpp(91) : warning C4800: 'const uint' : forcing value to bool 'true' or 'false' (performance warning)
        ....

        This seems to have been triggered by making _loopflags uint (was short).

        However, this warning does not make much sense nowadays, Visual Studio 2017 already got rid of it, and we already disable it in the JDK build, so the simplest solution would be to disable it for the hotspot build too.


          Attachments

            Issue Links

              Activity

                People

                Assignee:
                stuefe Thomas Stuefe
                Reporter:
                stuefe Thomas Stuefe
                Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                  Dates

                  Created:
                  Updated:
                  Resolved: