Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8209657

Refactor filemap.hpp to simplify integration with Serviceability Agent

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: P3
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 12
    • Component/s: hotspot
    • Subcomponent:
    • Resolved In Build:
      b09

      Description

      The FileMapHeader type declaration is duplicated between HotSpot (in filemap.hpp) and Serviceability Agent (in the following 3 files)

      http://hg.openjdk.java.net/jdk/jdk/file/d9f6e3ee7fcb/src/jdk.hotspot.agent/linux/native/libsaproc/ps_core.c#l224
      http://hg.openjdk.java.net/jdk/jdk/file/d9f6e3ee7fcb/src/jdk.hotspot.agent/solaris/native/libsaproc/saproc.cpp#l508
      http://hg.openjdk.java.net/jdk/jdk/file/d9f6e3ee7fcb/src/jdk.hotspot.agent/macosx/native/libsaproc/ps_core.c#l226

      SA uses only a small portion of FileMapHeader. We should move that into a common header file to avoid the code duplication.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                iklam Ioi Lam
                Reporter:
                iklam Ioi Lam
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: