Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8210713

Let CollectedHeap::ensure_parsability() take care of TLAB statistics gathering

    Details

    • Type: Enhancement
    • Status: Resolved
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: 12
    • Fix Version/s: 12
    • Component/s: hotspot
    • Labels:
      None
    • Subcomponent:
      gc
    • Resolved In Build:
      b12

      Description

      A call to CollectedHeap::ensure_parsability(retire_tlabs), where retire_tlabs is true must always be preceded by a call to CollectedHeap::accumulate_statistics_all_tlabs(), otherwise we will loose TLAB statistics as it will be reset when the TLABs are retired. Instead of having all collectors do this dance and risk getting it wrong, I propose that we move this responsibility into ensure_parsability(), which will gather the TLAB statistics if it's told to retire all TLABs.

        Attachments

          Activity

            People

            • Assignee:
              pliden Per Liden
              Reporter:
              pliden Per Liden
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: