Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8210794

Incorrect escaping of $ORIGIN in native test libraries

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 14
    • Component/s: infrastructure
    • Labels:
    • Subcomponent:
    • Resolved In Build:
      b16

      Description

      After building test-image on Linux, I see a non-sensical:

       $ readelf -ld ./linux-x86_64-normal-server-release/images/test/hotspot/jtreg/native/libintrpthrd003.so | grep RUNPATH
       0x000000000000001d (RUNPATH) Library runpath: [RIGIN]

      In the corresponding cmdline file I see:

       -Wl,-rpath,\RIGIN

      which is likely due to use of $ORIGIN in a Makefile where the $ was not $$-escaped.

      That attempt to use $ORIGIN obviously failed, but the tests still work - maybe we shouldn't be trying?

      ---

      In the same cmdline file I see -L flags pointing to the location of libjvm.so but no -ljvm flag to actually use it !

      I suggest ensuring that test libs are built with the appropriate linker flag to make undefined symbols an error - that should cause build failures - and then add back in the missing -ljvm to re-fix the build.

        Attachments

          Activity

            People

            Assignee:
            erikj Erik Joelsson
            Reporter:
            martin Martin Buchholz
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: