Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8211048

SA: cleanup: remove unwanted callback routine wrapper_fill_cframe_list() and related comments in saproc.cpp

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: P4
    • Resolution: Won't Fix
    • Affects Version/s: 8u122, 9, 10, 11
    • Fix Version/s: tbd
    • Component/s: hotspot
    • Labels:
      None
    • Subcomponent:
    • CPU:
      sparc_64
    • OS:
      solaris

      Description

      jIn src/jdk.hotspot.agent/solaris/native/libsaproc/saproc.cpp, the following comments
       
       452
       453 // Pstack_iter() proc_stack_f callback prior to Nevada-B159
       
       476 // Pstack_iter() proc_stack_f callback in Nevada-B159 or later
       477 /**ARGSUSED**/
       
      would not be required anymore. And we would not need the wrapper to the callback routine fill_cframe_list() -- as in, we would need only one routine with the appropriate arguments passed. This got missed while fixing JDK-8164383 : jhsdb dumps core on Solaris 12 when loading dumped core. Pre-8164383, fill_cframe_list() or wrapper_fill_cframe_list() would get called, depending on whether SOLARIS_11_B159_OR_LATER was set or not.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              jgeorge Jini George (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: