Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8211063

StdLibTest improvements

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: P3
    • Resolution: Fixed
    • Affects Version/s: repo-panama
    • Fix Version/s: repo-panama
    • Component/s: tools
    • Labels:
    • Subcomponent:
    • CPU:
      generic
    • OS:
      generic

      Description

      See the panama-dev email from Jorn Vernee:

      http://mail.openjdk.java.net/pipermail/panama-dev/2018-September/002773.html

      [excerpt from the email]

      This patch fixes 3 things:

      1.) 'puts' returns a non-negative value on success [1], but the test was
      testing > 0. I changed it to >= 0, since the MSVC implementation returns
      exactly 0.

      2.) Switched the test_time test from testing localtime(), which is
      locale dependent to testing gmtime() which always uses the GMT timezone,
      since the locale dependency was giving trouble in cygwin [2].

      3.) Also for the test_time test, I changed the way the test parameters
      are being generated, since it was apparently generating invalid values
      for windows, so the native function was returning null, and the test was
      failing.

      Since I'm not a committer someone else will have to create a commit and
      push this.

      [excerpt ends]

        Attachments

          Activity

            People

            Assignee:
            sundar Sundararajan Athijegannathan
            Reporter:
            sundar Sundararajan Athijegannathan
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: