Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8211950

Deprecate the check if a JVMTI collector is present assertion

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 12
    • Component/s: hotspot
    • Labels:
      None
    • Subcomponent:
    • Resolved In Build:
      b16

      Description

      When the heap sampler was added, a lot of various paths could lead to where the allocation could happen and it was not trivial to see if a collector was present.

      Since then, a refactor took place and the code actually has merged all paths to a single memAllocator path that then does the collection and allocation in the same spot.

      Therefore, the assertion code is no longer needed.

      Furthermore, it is a nop right now, it basically says:
         Say there is a collector
         Check if there is a collector
         Say there is no longer a collector

      And there is no path that would not make both statements not true.

        Attachments

          Activity

            People

            • Assignee:
              jcbeyler Jean Christophe Beyler
              Reporter:
              jcbeyler Jean Christophe Beyler
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: