Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8213346

Re-implement shared dictionary using CompactHashtable

    Details

    • Type: Enhancement
    • Status: Resolved
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: 12
    • Fix Version/s: 12
    • Component/s: hotspot
    • Labels:
    • Subcomponent:
    • Resolved In Build:
      b20

      Description

      The current implementation of SharedDictionary is quite awkward. There's a lot of ad-hoc calculation for various sizes such as number of bytes used in the buckets. See:

      http://hg.openjdk.java.net/jdk/jdk/file/ca309ee4fd92/src/hotspot/share/memory/metaspaceShared.cpp#l1327

      We should change it to be based on CompactHashtable to take advantage of existing code that already deal with various hashtables in the CDS archive. That will also use less space.

      While on this, we should also implement the following FIXME for a little space saving.

      http://hg.openjdk.java.net/jdk/jdk/file/ca309ee4fd92/src/hotspot/share/classfile/systemDictionaryShared.cpp#l886

      int SharedDictionaryEntry::finalize_verification_constraints() {
            ....
            // FIXME: change this to be done after relocation, so we can use symbol offset??
       

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                iklam Ioi Lam
                Reporter:
                iklam Ioi Lam
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: