Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8214250

ZGC: Missing load barrier in java.io.ObjectStreamClass.writeNonProxy()

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: P3
    • Resolution: Duplicate
    • Affects Version/s: 12
    • Fix Version/s: 12
    • Component/s: hotspot
    • Labels:

      Description

      The serial benchmark in SPECjvm2008 crashes because of a missing C2 load barrier in java.io.ObjectStreamClass.writeNonProxy().

      ObjectStreamClass.writeNonProxy() calls ObjectStreamClass.getSerialVersionUID(), which gets inlined. ObjectStreamClass.getSerialVersionUID() calls suid.longValue(), which also gets inlined and where suid is a java.lang.Long reference member of ObjectStreamClass. The load of suid is not followed by a load barrier.

      .... 
      mov 0x10(%rsp),%r10
      test %r10,0x20(%r15)
      jne loc_00000a06
      mov (%rsp),%r13
      test %r10,%r10
      je loc_00002a98
      mov 0x30(%r13),%r10 // load of suid (java.lang.Long)
      >>>>>> missing load barrier here!
      mov 0x10(%r10),%rdx // inlined call to suid.longValue()
      mov 0x8(%rsp),%r14
      mov 0x20(%r14),%r11
      test %r11,0x20(%r15)
      jne loc_00000a18
      mov 0x10(%r11),%ebx
      mov %ebx,%r9d
      ...


        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                neliasso Nils Eliasson
                Reporter:
                pliden Per Liden
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: