Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8215644

Clean up globalDefinitions_<compiler>.hpp

    Details

    • Subcomponent:
    • Resolved In Build:
      b03

      Description

      Comments from coleenp and kbarrett on cleanup needed for global_Definitions*.hpp:

      1. globalDefinitions_<compiler.hpp. has #defines for pragma interface/pragma implementation that can be removed.

      And then there's these other macros for super old GCC compilers. No longer relevant.

      // Portability macros
      #define PRAGMA_INTERFACE #pragma interface
      #define PRAGMA_IMPLEMENTATION #pragma implementation

      #if (__GNUC__ == 2) && (__GNUC_MINOR__ < 95)
      #define TEMPLATE_TABLE_BUG
      #endif
      #if (__GNUC__ == 2) && (__GNUC_MINOR__ >= 96)
      #define CONST_SDM_BUG
      #endif


      2. These should go in globals.hpp because that is the only place they are used.

      //----------------------------------------------------------------------------------------------------
      // Default and minimum StringTable and SymbolTable size values
      // Must be a power of 2

      const size_t defaultStringTableSize = NOT_LP64(1024) LP64_ONLY(65536);
      const size_t minimumStringTableSize = 128;

      const size_t defaultSymbolTableSize = 32768; // 2^15
      const size_t minimumSymbolTableSize = 1024;


      3. There are 'Forward' declarations of frequently used classes. Some don't exist and should be removed.


      4. These functions may longer be used and should be deleted:

      //----------------------------------------------------------------------------------------------------
      // Avoid non-portable casts with these routines (DEPRECATED)

      // NOTE: USE Bytes class INSTEAD WHERE POSSIBLE
      // Bytes is optimized machine-specifically and may be much faster then the portable routines below.

      ...

      Up to

      // Pack and extract shorts to/from ints:


        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                hseigel Harold Seigel
                Reporter:
                hseigel Harold Seigel
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: