Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8216743

Regression: Many panama foreign tests fail on Mac after fix for JDK-8216485

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: P2
    • Resolution: Fixed
    • Affects Version/s: repo-panama
    • Fix Version/s: None
    • Component/s: tools
    • Labels:
      None
    • Subcomponent:
    • CPU:
      x86_64
    • OS:
      os_x

      Description

      Many panama foreign tests fail on Mac after fix for JDK-8216485

      SystemABI.getInstance() fails by throwing UnsupportedOperationException on Mac. This is because "os.arch" is checked to be "amd64" but on Mac "os.arch" value is "x86_64". The following change is needed to fix this issue:

      hg diff
      diff -r 59c605f5cfb5 src/java.base/share/classes/jdk/internal/foreign/abi/SystemABI.java
      --- a/src/java.base/share/classes/jdk/internal/foreign/abi/SystemABI.java Fri Jan 11 17:18:11 2019 +0100
      +++ b/src/java.base/share/classes/jdk/internal/foreign/abi/SystemABI.java Mon Jan 14 11:45:09 2019 +0530
      @@ -126,7 +126,7 @@
           static SystemABI getInstance() {
               String arch = System.getProperty("os.arch");
               String os = System.getProperty("os.name");
      - if (arch.equals("amd64")) {
      + if (arch.equals("amd64") || arch.equals("x86_64")) {
                   if (os.startsWith("Windows")) {
                       return Windowsx64ABI.getInstance();
                   } else {

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              sundar Sundararajan Athijegannathan
              Reporter:
              sundar Sundararajan Athijegannathan
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: