Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8217522

Missing barriers in some java_lang_String assertion code after JDK-8217442

    XMLWordPrintable

    Details

    • Subcomponent:
      gc
    • Resolved In Build:
      b05
    • Verification:
      Not verified

      Description

      java_lang_String class methods have assertions like:
      assert(oopDesc::equals_raw(value, java_lang_String::value(java_string))
      The naked oop comparison can fail if value moved for GC like Shenandoah, should use
      assert(oopDesc::equals(value, java_lang_String::value(java_string)) instead.

      The raw equal comparisons were introduced in JDK-8217442, but only manifested after JDK-8213229, because references in stringtable are not longer updated at safepoints after JDK-8213229.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              zgu Zhengyu Gu
              Reporter:
              zgu Zhengyu Gu
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: