Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8217782

Spill detection broken after JDK-8217716

    Details

    • Subcomponent:
    • Resolved In Build:
      b06
    • CPU:
      generic
    • OS:
      generic

      Description

      For easy reproducer, run "richards" from Octane. You'd need the nashorn.jar from 8u.

      jdk/jdk @ 97cf88608d76 (8217264: HttpClient: Blocking operations in mapper function do not work as documented)

      ~/trunks/jdk-jdk/test/nashorn $ ~/trunks/jdk-jdk/build/linux-x86_64-server-release/images/jdk/bin/java -jar ~/Install/jdk8u191-rh/jre/lib/ext/nashorn.jar -scripting --log=time script/basic/run-octane.js -- --iterations 5 richards --verbose
      Warning: The jjs tool is planned to be removed from a future JDK release
      [richards] loading 'richards' [richards.js]... /home/shade/trunks/jdk-jdk/test/nashorn/script/basic/../external/octane/richards.js
      [richards] running 'richards' for 5 iterations of no less than 5 seconds
      [richards] warmup finished 181008 ops/minute
      [richards] iteration 1 finished 230652 ops/minute
      [richards] iteration 2 finished 230448 ops/minute
      [richards] iteration 3 finished 226632 ops/minute

      jdk/jdk @ d927fc999582 (8217716: Remove dead code in PhaseChaitin)

      ~/trunks/jdk-jdk/test/nashorn $ ~/trunks/jdk-jdk/build/linux-x86_64-server-release/images/jdk/bin/java -jar ~/Install/jdk8u191-rh/jre/lib/ext/nashorn.jar -scripting --log=time script/basic/run-octane.js -- --iterations 5 richards --verbose
      Warning: The jjs tool is planned to be removed from a future JDK release
      [richards] loading 'richards' [richards.js]... /home/shade/trunks/jdk-jdk/test/nashorn/script/basic/../external/octane/richards.js
      [richards] running 'richards' for 5 iterations of no less than 5 seconds
      [richards] warmup finished 3561 ops/minute
      [richards] iteration 1 finished 4773 ops/minute
      [richards] iteration 2 finished 12264 ops/minute
      [richards] iteration 3 finished 12302 ops/minute
      [richards] iteration 4 finished 12614 ops/minute
      [richards] iteration 5 finished 12583 ops/minute

      There is ~19x performance hit on richards, and there are similar hits on other Octane benchmarks. It looks to me the change was not very innocuous.

      Richards seems to revert back to original performance when Chaitin cleanup is partially reverted with:
       http://cr.openjdk.java.net/~shade/8217782/partial-revert.patch

      jdk/jdk @ b743968ad646 (8217733: Minor RunTest fixes):

      ~/trunks/jdk-jdk/test/nashorn $ ~/trunks/jdk-jdk/build/linux-x86_64-server-release/images/jdk/bin/java -jar ~/Install/jdk8u191-rh/jre/lib/ext/nashorn.jar -scripting --log=time script/basic/run-octane.js -- --iterations 5 richards --verbose
      Warning: The jjs tool is planned to be removed from a future JDK release
      [richards] loading 'richards' [richards.js]... /home/shade/trunks/jdk-jdk/test/nashorn/script/basic/../external/octane/richards.js
      [richards] running 'richards' for 5 iterations of no less than 5 seconds
      [richards] warmup finished 3681 ops/minute
      [richards] iteration 1 finished 5276 ops/minute
      [richards] iteration 2 finished 12504 ops/minute
      [richards] iteration 3 finished 12535 ops/minute
      [richards] iteration 4 finished 12727 ops/minute
      [richards] iteration 5 finished 12792 ops/minute

      jdk/jdk @ b743968ad646 (8217733: Minor RunTest fixes) + partial-revert.patch

      ~/trunks/jdk-jdk/test/nashorn $ ~/trunks/jdk-jdk/build/linux-x86_64-server-release/images/jdk/bin/java -jar ~/Install/jdk8u191-rh/jre/lib/ext/nashorn.jar -scripting --log=time script/basic/run-octane.js -- --iterations 5 richards --verbose
      Warning: The jjs tool is planned to be removed from a future JDK release
      [richards] loading 'richards' [richards.js]... /home/shade/trunks/jdk-jdk/test/nashorn/script/basic/../external/octane/richards.js
      [richards] running 'richards' for 5 iterations of no less than 5 seconds
      [richards] warmup finished 182856 ops/minute
      [richards] iteration 1 finished 234636 ops/minute
      [richards] iteration 2 finished 232332 ops/minute
      [richards] iteration 3 finished 230616 ops/minute
      [richards] iteration 4 finished 232644 ops/minute
      [richards] iteration 5 finished 233316 ops/minute

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                redestad Claes Redestad
                Reporter:
                shade Aleksey Shipilev
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: