Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8218460

Test generation scripts do not invoke stream preprocessor correctly

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 13
    • Component/s: core-libs
    • Labels:
    • Subcomponent:
    • Resolved In Build:
      b07

      Description

      These scripts

      test/jdk/java/lang/invoke/VarHandles/generate-vh-tests.sh
      test/jdk/java/nio/Buffer/genBasic.sh
      test/jdk/java/nio/Buffer/genCopyDirectMemory.sh
      test/jdk/java/nio/Buffer/genOrder.sh
      test/jdk/java/util/Formatter/genBasic.sh

      use the stream preprocessor build.tools.spp.Spp to generate tests from templates. Spp requires that its input and output be specified as

      java build.tools.spp.Spp -i$input -o$output

      and not as

      java build.tools.spp.Spp <$input >$output

      which is to say *not* via stdin and stdout. Presumably Spp was changed without updating these scripts. The scripts now fail to generate the expected tests with a NullPointerException:

      $ sh ./genBasic.sh
      Exception in thread "main" java.lang.NullPointerException
      at java.base/java.io.FileInputStream.<init>(FileInputStream.java:147)
      at java.base/java.io.FileInputStream.<init>(FileInputStream.java:110)
      at build.tools.spp.Spp.main(Spp.java:98)

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                bpb Brian Burkhalter
                Reporter:
                bpb Brian Burkhalter
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: