Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8219245

Don't call BarrierSetAssembler directly from MacroAssembler::access_* helpers

    Details

    • Type: Enhancement
    • Status: Open
    • Priority: P4
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: tbd
    • Component/s: hotspot
    • Labels:
      None
    • Subcomponent:
      gc
    • CPU:
      x86, aarch64
    • OS:
      generic

      Description

      MacroAssembler::access_load_at() and MacroAssembler::access_store_at() are checking for raw access, and if so, call directly to corresponding BarrierSetAssembler methods. Instead they should do the proper virtual call, adorned with AS_RAW, and implementations should do the right thing accordingly, e.g. passing up the call without card-marking or such.

        Attachments

          Activity

            People

            • Assignee:
              rkennke Roman Kennke
              Reporter:
              rkennke Roman Kennke
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated: