Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8220512

Deoptimize redefinition functions that have dirty ICs

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: 13
    • Fix Version/s: 13
    • Component/s: hotspot
    • Labels:
      None
    • Subcomponent:
    • Resolved In Build:
      b13

      Description

      Use metadata section in nmethod to decide when to deoptimize nmethods after redefinition. This walk includes the Method* in evol_method dependencies because the Method* is added there.

      This might deoptimize more things but then we don't have to call clear_inline_caches. [~eosterlund] is trying to remove that.

      I don't think this can remove evol_method dependencies. We still have to assert_evol_method to get the Method* in the metadata section. It also seems to be used to check_dependencies:
          // The point of the whole exercise: Is this dep still OK?
          Klass* check_dependency() {
            Klass* result = check_klass_dependency(NULL);
            if (result != NULL) return result;
            return check_call_site_dependency(NULL);
          }

      check_klass_dependency has a case for evol_method dependencies.

      Also make metadata_do take a closure.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              coleenp Coleen Phillimore
              Reporter:
              coleenp Coleen Phillimore
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: