Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8221641

Follow up code clean up for JDK-8221582

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: P3
    • Resolution: Fixed
    • Affects Version/s: internal
    • Fix Version/s: internal
    • Component/s: tools
    • Labels:

      Description

      JDK-8221582 addressed rename of jvm-args option to java-options.
      Webrev at http://cr.openjdk.java.net/~herrick/8221582/ indicated that not just public interfaces were affected with the rename. However not all tokens containing "jvm" substring was touched.

      It would make sense to at least replace JVMArgs with JavaArgs substring:
      ---
      ASEMENYU-LAP+asemenyu@ASEMENYU-LAP /cygdrive/c/ade/work/as/jds/work/10_sandbox/jdk10/open/src/jdk.jpackage
      $ find . -name '*.cpp' -o -name '*.h' | xargs.exe grep JVMArgs
      ./share/native/libapplauncher/Helpers.cpp: Helpers::GetJVMArgsFromConfig(IPropertyContainer* config) {
      ./share/native/libapplauncher/Helpers.cpp: OrderedMap<TString, TString> JVMArgs =
      ./share/native/libapplauncher/Helpers.cpp: Helpers::GetJVMArgsFromConfig(&propertyFile);
      ./share/native/libapplauncher/Helpers.cpp: Container->AppendSection(keys[CONFIG_SECTION_JVMOPTIONS], JVMArgs);
      ./share/native/libapplauncher/Helpers.h: GetJVMArgsFromConfig(IPropertyContainer* config);
      ./share/native/libapplauncher/JavaVirtualMachine.cpp: options.AppendValues(package.GetJVMArgs());
      ./share/native/libapplauncher/Package.cpp: ReadJVMArgs(config);
      ./share/native/libapplauncher/Package.cpp:void Package::ReadJVMArgs(ISectionalPropertyContainer* Config) {
      ./share/native/libapplauncher/Package.cpp: FBootFields->FJVMArgs);
      ./share/native/libapplauncher/Package.cpp: FBootFields->FJVMArgs);
      ./share/native/libapplauncher/Package.cpp: FBootFields->FJVMArgs);
      ./share/native/libapplauncher/Package.cpp:OrderedMap<TString, TString> Package::GetJVMArgs() {
      ./share/native/libapplauncher/Package.cpp: return FBootFields->FJVMArgs;
      ./share/native/libapplauncher/Package.h: OrderedMap<TString, TString> FJVMArgs;
      ./share/native/libapplauncher/Package.h: void ReadJVMArgs(ISectionalPropertyContainer* Config);
      ./share/native/libapplauncher/Package.h: OrderedMap<TString, TString> GetJVMArgs();
      ---

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                herrick Andy Herrick
                Reporter:
                asemenyuk Alexey Semenyuk
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: