Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8222286

Fix for JDK-8213419 is broken on s390

    Details

    • Subcomponent:
    • Understanding:
      Fix Understood
    • Introduced In Version:
      12
    • CPU:
      other
    • OS:
      linux

      Description

      On s390, calls to log2_intptr with a size_t are ambiguous, so an explicit cast to uintptr_t is necessary.

      diff --git openjdk.orig/jdk/src/hotspot/share/runtime/os.cpp openjdk/jdk/src/hotspot/share/runtime/os.cpp
      --- openjdk.orig/src/hotspot/share/runtime/os.cpp
      +++ openjdk/src/hotspot/share/runtime/os.cpp
      @@ -1368,7 +1368,7 @@
       }
       
       void os::set_memory_serialize_page(address page) {
      - int count = log2_intptr(sizeof(class JavaThread)) - log2_int(64);
      + int count = log2_intptr((uintptr_t) sizeof(class JavaThread)) - log2_int(64);
         _mem_serialize_page = (volatile int32_t *)page;
         // We initialize the serialization page shift count here
         // We assume a cache line size of 64 bytes

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                andrew Andrew Hughes
                Reporter:
                andrew Andrew Hughes
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated: