Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: 13
    • Fix Version/s: 13
    • Component/s: hotspot
    • Subcomponent:
    • Resolved In Build:
      b18
    • CPU:
      generic
    • OS:
      generic

      Description

      This sub-task captures updates to the baseline code that came up
      during the Async Monitor Deflation project design review and code
      review email threads.
       
      The cleanups include:

      - rename ObjectMonitor::_count -> ObjectMonitor::_contentions
      - update comment in objectMonitor.hpp for _contentions field declaration
      - delete unused count_offset_in_bytes()
      - delete count() getter
      - replace uses of 'count()' with 'contentions()'
      - deleted declared but undefined set_count()
      - delete some stale TODO-FIXME comments
      - update comments in ObjectSynchronizer::FastHashCode()
      - change 'hashcode' -> 'hash code' for consistency; the consistent
        forms are: 'hash code', 'Hash Code', 'hashCode' and 'HashCode'
      - add more assert() diagnostics for incoming object header in inflate()
      - add more assert() diagnostics for enter()'s TrySpin() branch
      - add more assert() diagnostics in ObjectMonitor::clear()
      - add more assert() and guarantee() diagnostics in
        ObjectSynchronizer::deflate_monitor()
      - get rid of unnecessary '(address)' casts

      One of the changes is in print output:

      - st->print("{count=0x%08x,waiters=0x%08x"
      + st->print("{contentions=0x%08x,waiters=0x%08x"

      I searched for tests that depended on '{count=.*,waiters=' and did not find any.

        Attachments

          Activity

            People

            • Assignee:
              dcubed Daniel Daugherty
              Reporter:
              dcubed Daniel Daugherty
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: