Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8223080

Build team code review requests.

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: P3
    • Resolution: Fixed
    • Affects Version/s: internal
    • Fix Version/s: internal
    • Component/s: tools
    • Labels:

      Description

      1.) remove "-parameters" javac option (in CompileJavaModules.gmk) or document why it is needed in jpackage.

      2.) in Modules.gmk, use the new macro isTargetOs() to check things like target OS. The new macro is called like this:
          ifeq ($(call isTargetOs, windows macosx linux), false)
      Same in Lib-jdk.jpackage.gmk and Launcher-jdk.jpackage.gmk:
          ifeq ($(call isTargetOs, windows), true)

        Attachments

          Activity

            People

            • Assignee:
              herrick Andy Herrick
              Reporter:
              herrick Andy Herrick
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: