Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8223448

Shenandoah disabled barriers blocks omit LRB

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: P3
    • Resolution: Fixed
    • Affects Version/s: 8-shenandoah, 11-shenandoah, 13
    • Fix Version/s: 13
    • Component/s: hotspot
    • Subcomponent:
      gc
    • Resolved In Build:
      b20

      Description

      There are missing clauses that check/disable LRB in initial Shenandoah configuration.

      diff -r 3a75a903a488 src/hotspot/share/gc/shenandoah/shenandoahArguments.cpp
      --- a/src/hotspot/share/gc/shenandoah/shenandoahArguments.cpp Mon May 06 19:20:26 2019 +0200
      +++ b/src/hotspot/share/gc/shenandoah/shenandoahArguments.cpp Mon May 06 19:25:02 2019 +0200
      @@ -45,6 +45,7 @@
         FLAG_SET_DEFAULT(ShenandoahGCHeuristics, "passive");
       
         FLAG_SET_DEFAULT(ShenandoahSATBBarrier, false);
      + FLAG_SET_DEFAULT(ShenandoahLoadRefBarrier, false);
         FLAG_SET_DEFAULT(ShenandoahKeepAliveBarrier, false);
         FLAG_SET_DEFAULT(ShenandoahStoreValEnqueueBarrier, false);
         FLAG_SET_DEFAULT(ShenandoahCASBarrier, false);
      @@ -106,6 +107,7 @@
         // C2 barrier verification is only reliable when all default barriers are enabled
         if (ShenandoahVerifyOptoBarriers &&
                 (!FLAG_IS_DEFAULT(ShenandoahSATBBarrier) ||
      + !FLAG_IS_DEFAULT(ShenandoahLoadRefBarrier) ||
                  !FLAG_IS_DEFAULT(ShenandoahKeepAliveBarrier) ||
                  !FLAG_IS_DEFAULT(ShenandoahStoreValEnqueueBarrier) ||
                  !FLAG_IS_DEFAULT(ShenandoahCASBarrier) ||

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                shade Aleksey Shipilev
                Reporter:
                shade Aleksey Shipilev
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: