Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8227367

Missing @Override annotations in javafx.graphics/src/main/java/com/sun/prism/*

    XMLWordPrintable

    Details

      Description

      Many of the classes in javafx.graphics/src/main/java/com/sun/prism are missing @Override annotations and have a few instances of using a static method on an instance of a class (as opposed to the class itself). This is always good practice but in this specific case it will help anyone trying to implement a new rendering pipeline (Vulkan, DirectX 11/12, etc.) as it makes it easier to see what methods are required to be implemented as they are used by Prism and which methods are implementation details.

      I will also make the formatting of the empty traceDispose methods consistent (putting opening and closing curly brackets on same line) in the classes that are missing the annotations.

        Attachments

          Activity

            People

            Assignee:
            mennen Michael Ennen
            Reporter:
            mennen Michael Ennen
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: