Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8228673

Remove develop flag StrictSafepointChecks

    XMLWordPrintable

    Details

    • Type: Enhancement
    • Status: Resolved
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: 14
    • Fix Version/s: 14
    • Component/s: hotspot
    • Subcomponent:
    • Resolved In Build:
      b08

      Description

      There doesn't seem to be a reason to turn off these checks.

      One reason may have been to have a quick return for product:

      - debug_only(if (StrictSafepointChecks) _thread->check_for_valid_safepoint_state(false);)
      + _thread->check_for_valid_safepoint_state(false);

      But, check_for_valid-safepoint_state is declared in thread.hpp as:

        void check_for_valid_safepoint_state(bool potential_vm_operation) PRODUCT_RETURN;


      So doesn't require debug_only or a const false flag to not generate a call in production.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              coleenp Coleen Phillimore
              Reporter:
              coleenp Coleen Phillimore
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: