Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8228695

[lworld] EnableValhallaC1 and TieredStopAtLevel options should obey TieredCompilation

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: P3
    • Resolution: Fixed
    • Affects Version/s: repo-valhalla
    • Fix Version/s: repo-valhalla
    • Component/s: hotspot
    • Labels:

      Description

      See http://hg.openjdk.java.net/valhalla/valhalla/file/2718fd83971d/src/hotspot/share/runtime/arguments.cpp#l2125

      It's possible to have the following combination of (invalid) option values:
           EnableValhallaC1 = true
           TieredStopAtLevel = 1
           TieredCompilation = false

      This will cause WhiteBox::compile_method(... int comp_level ....) to always fail because both comp_level=1 and comp_level==4 will be rejected.

      The fix is to allow TieredCompilation to decide the value of EnableValhallaC1 and TieredStopAtLevel. This will be similar to the behavior in the jdk/jdk repo without Valhalla:

        if (EnableValhalla) {
          if (!TieredCompilation) {
            if (!FLAG_IS_DEFAULT(EnableValhallaC1) && EnableValhallaC1) {
              warning("EnableValhallaC1 is disabled because TieredCompilation is disabled");
            }
            FLAG_SET_CMDLINE(EnableValhallaC1, false);
            if (!FLAG_IS_DEFAULT(TieredStopAtLevel) && TieredStopAtLevel != 4) {
              warning("TieredStopAtLevel is reset to 4 because TieredCompilation is disabled");
            }
            FLAG_SET_CMDLINE(TieredStopAtLevel, 4);
          }







          

        Attachments

          Activity

            People

            • Assignee:
              iklam Ioi Lam
              Reporter:
              iklam Ioi Lam
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: