Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8229231

Shenandoah: Non-PCH builds failed after JDK-8224932

    Details

    • Type: Bug
    • Status: Closed
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: 14
    • Fix Version/s: None
    • Component/s: hotspot
    • Labels:
      None
    • Subcomponent:
      gc

      Description

      Aleksey reported shenandoah/jdk builds broken on Windows and Linux.

      c:\cygwin64\home\windows\worker\shenandoah-jdkX-windows\build\src\hotspot\share\gc/shenandoah/shenandoahLock.hpp(72)
      : error C2653: 'SafepointSynchronize' : is not a class or namespace name
      c:\cygwin64\home\windows\worker\shenandoah-jdkX-windows\build\src\hotspot\share\gc/shenandoah/shenandoahLock.hpp(72)
      : error C3861: 'is_at_safepoint': identifier not found

      and

      /home/buildbot/worker/shenandoah-jdkX-linux/build/src/hotspot/share/gc/shenandoah/shenandoahLock.cpp:26:
      /home/buildbot/worker/shenandoah-jdkX-linux/build/src/hotspot/share/gc/shenandoah/shenandoahLock.hpp: In
      member function ‘void ShenandoahLock::assert_owned_by_current_thread_or_safepoint()’:
      /home/buildbot/worker/shenandoah-jdkX-linux/build/src/hotspot/share/gc/shenandoah/shenandoahLock.hpp:73:13:
      error: ‘SafepointSynchronize’ has not been declared
                  (SafepointSynchronize::is_at_safepoint() && thr->is_VM_thread()),
                   ^
      /home/buildbot/worker/shenandoah-jdkX-linux/build/src/hotspot/share/utilities/debug.hpp:56:9: note:
      in definition of macro ‘vmassert’
         if (!(p)) { \
               ^
      /home/buildbot/worker/shenandoah-jdkX-linux/build/src/hotspot/share/gc/shenandoah/shenandoahLock.hpp:72:5:
      note: in expansion of macro ‘assert’
           assert((_state == locked && _owner == thr) ||
           ^~~~~~

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                zgu Zhengyu Gu
                Reporter:
                zgu Zhengyu Gu
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: