Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8229808

javaVFrame::print_lock_info_on fails to disable extra printing

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 14
    • Component/s: hotspot
    • Labels:
      None
    • Subcomponent:
    • Resolved In Build:
      b11

      Description

      There's code that sets a markWord to 0 and expects extra printing to be disabled. However, the markWord is never used after that point, so either the comment is wrong or the disabling of extra printing is broken. See:

              markWord mark(markWord::zero);
              const char *lock_state = "locked"; // assume we have the monitor locked
              if (!found_first_monitor && frame_count == 0) {
                // If this is the first frame and we haven't found an owned
                // monitor before, then we need to see if we have completed
                // the lock or if we are blocked trying to acquire it. Only
                // an inflated monitor that is first on the monitor list in
                // the first frame can block us on a monitor enter.
                mark = monitor->owner()->mark();
                if (mark.has_monitor() &&
                    ( // we have marked ourself as pending on this monitor
                      mark.monitor() == thread()->current_pending_monitor() ||
                      // we are not the owner of this monitor
                      !mark.monitor()->is_entered(thread())
                    )) {
                  lock_state = "waiting to lock";
                } else {
                  // We own the monitor which is not as interesting so
                  // disable the extra printing below.
                  mark = markWord(markWord::zero);
                }
              }
              print_locked_object_class_name(st, Handle(THREAD, monitor->owner()), lock_state);

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                dholmes David Holmes
                Reporter:
                stefank Stefan Karlsson
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: