Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8153224 Monitor deflation prolong safepoints
  3. JDK-8230184

rename, whitespace, indent and comments changes in preparation for lock free Monitor lists

    Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: 14
    • Fix Version/s: 14
    • Component/s: hotspot
    • Subcomponent:
    • Resolved In Build:
      b12
    • CPU:
      generic
    • OS:
      generic

      Description

      Part of the Async Monitor Deflation project (JDK-8153224) will
      be changing to lock-free Monitor list management algorithms.

      A number of the variables and functions that have to be touched
      in order to have lock free Monitor list management have been
      commented on over the years as being in violation of the HotSpot
      style guide. Since we're touching those variables and functions
      anyway, we might as well rename them.

      However, the renaming work would make the code review for
      the lock free Monitor list management code much more difficult
      so we're splitting the renaming off into a separate bug.

      Along with the renaming, we're including whitespace, indent and
      comment changes that are not specific to either the Async Monitor
      Deflation project or lock free Monitor list management.

      Update: This isn’t a complete cleanup. I started with the list variable
      names and the functions that used them and added those to the
      cleanup list. So if there’s a function that didn’t intersect with the
      “primaries”, then I didn’t clean it up except for some globals like
      “Self” -> “self”.

      Perfect example is that ObjectMonitor.cpp isn’t touched, but
      ObjectMonitor.hpp is. ObjectMonitor.cpp never touched the list
      variables.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                dcubed Daniel Daugherty
                Reporter:
                dcubed Daniel Daugherty
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: