Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8231242

G1CollectedHeap::print_regions_on() does not print description for "OA" and "CA" regions

    XMLWordPrintable

    Details

    • Type: Enhancement
    • Status: Resolved
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: 14
    • Fix Version/s: 14
    • Component/s: hotspot
    • Labels:
    • Subcomponent:
      gc
    • Resolved In Build:
      b16

      Description

      This issue was reported by huangjia@loongson.cn

      When dumping the info of heap region, the description for "OA" and "CA" seems to be lost.
      -----------------------------------
      [4.544s][error][gc,verify] Heap Regions: E=young(eden), S=young(survivor), O=old, HS=humongous(starts), HC=humongous(continues), CS=collection set, F=free, A=archive, TAMS=top-at-mark-start (previous, next)
      [4.544s][error][gc,verify] | 0|0x000000060c800000, 0x000000060c900000, 0x000000060c900000|100%| O| |TAMS 0x000000060c900000, 0x000000060c800000| Untracked
      [4.544s][error][gc,verify] | 1|0x000000060c900000, 0x000000060c937a00, 0x000000060ca00000| 21%| O| |TAMS 0x000000060c937a00, 0x000000060c900000| Untracked
      [4.544s][error][gc,verify] | 2|0x000000060ca00000, 0x000000060ca00000, 0x000000060cb00000| 0%| F| |TAMS 0x000000060ca00000, 0x000000060ca00000| Untracked
      [4.544s][error][gc,verify] | 3|0x000000060cb00000, 0x000000060cb00000, 0x000000060cc00000| 0%| F| |TAMS 0x000000060cb00000, 0x000000060cb00000| Untracked
      [4.544s][error][gc,verify] | 4|0x000000060cc00000, 0x000000060cc00000, 0x000000060cd00000| 0%| F| |TAMS 0x000000060cc00000, 0x000000060cc00000| Untracked
      [4.544s][error][gc,verify] | 5|0x000000060cd00000, 0x000000060cd2ade8, 0x000000060ce00000| 16%| S|CS|TAMS 0x000000060cd00000, 0x000000060cd00000| Complete
      [4.544s][error][gc,verify] | 6|0x000000060ce00000, 0x000000060ce00000, 0x000000060cf00000| 0%| F| |TAMS 0x000000060ce00000, 0x000000060ce00000| Untracked
      [4.544s][error][gc,verify] | 7|0x000000060cf00000, 0x000000060cf98410, 0x000000060d000000| 59%| E| |TAMS 0x000000060cf00000, 0x000000060cf00000| Complete
      [4.544s][error][gc,verify] |7990|0x00000007ffe00000, 0x00000007ffe54000, 0x00000007fff00000| 32%|OA| |TAMS 0x00000007ffe54000, 0x00000007ffe00000| Untracked
      [4.544s][error][gc,verify] |7991|0x00000007fff00000, 0x00000007fff70000, 0x0000000800000000| 43%|CA| |TAMS 0x00000007fff70000, 0x00000007fff00000| Untracked
      -----------------------------------

      It might be better to add them by the following fix
      -----------------------------------
      diff -r 778fc2dcbdaa src/hotspot/share/gc/g1/g1CollectedHeap.cpp
      --- a/src/hotspot/share/gc/g1/g1CollectedHeap.cpp Wed Sep 18 20:49:13 2019 -0400
      +++ b/src/hotspot/share/gc/g1/g1CollectedHeap.cpp Thu Sep 19 11:47:07 2019 +0800
      @@ -2378,6 +2378,7 @@
         st->print_cr("Heap Regions: E=young(eden), S=young(survivor), O=old, "
                      "HS=humongous(starts), HC=humongous(continues), "
                      "CS=collection set, F=free, A=archive, "
      + "OA=open archive, CA=closed archive, "
                      "TAMS=top-at-mark-start (previous, next)");
         PrintRegionClosure blk(st);
         heap_region_iterate(&blk);
      -----------------------------------

      - After the patch
      -----------------------------------
      [5.036s][error][gc,verify] Heap Regions: E=young(eden), S=young(survivor), O=old, HS=humongous(starts), HC=humongous(continues), CS=collection set, F=free, A=archive, OA=open archive, CA=closed archive, TAMS=top-at-mark-start (previous, next)
      [5.036s][error][gc,verify] | 0|0x000000060c800000, 0x000000060c900000, 0x000000060c900000|100%| O| |TAMS 0x000000060c900000, 0x000000060c800000| Untracked
      [5.036s][error][gc,verify] | 1|0x000000060c900000, 0x000000060c939c00, 0x000000060ca00000| 22%| O| |TAMS 0x000000060c939c00, 0x000000060c900000| Untracked
      [5.036s][error][gc,verify] | 2|0x000000060ca00000, 0x000000060ca00000, 0x000000060cb00000| 0%| F| |TAMS 0x000000060ca00000, 0x000000060ca00000| Untracked
      [5.036s][error][gc,verify] | 3|0x000000060cb00000, 0x000000060cb00000, 0x000000060cc00000| 0%| F| |TAMS 0x000000060cb00000, 0x000000060cb00000| Untracked
      [5.036s][error][gc,verify] | 4|0x000000060cc00000, 0x000000060cc00000, 0x000000060cd00000| 0%| F| |TAMS 0x000000060cc00000, 0x000000060cc00000| Untracked
      [5.036s][error][gc,verify] | 5|0x000000060cd00000, 0x000000060cd25170, 0x000000060ce00000| 14%| S|CS|TAMS 0x000000060cd00000, 0x000000060cd00000| Complete
      [5.036s][error][gc,verify] | 6|0x000000060ce00000, 0x000000060ce00000, 0x000000060cf00000| 0%| F| |TAMS 0x000000060ce00000, 0x000000060ce00000| Untracked
      [5.036s][error][gc,verify] | 7|0x000000060cf00000, 0x000000060cf98390, 0x000000060d000000| 59%| E| |TAMS 0x000000060cf00000, 0x000000060cf00000| Complete
      [5.036s][error][gc,verify] |7990|0x00000007ffe00000, 0x00000007ffe54000, 0x00000007fff00000| 32%|OA| |TAMS 0x00000007ffe54000, 0x00000007ffe00000| Untracked
      [5.036s][error][gc,verify] |7991|0x00000007fff00000, 0x00000007fff70000, 0x0000000800000000| 43%|CA| |TAMS 0x00000007fff70000, 0x00000007fff00000| Untracked
      -----------------------------------

        Attachments

          Activity

            People

            Assignee:
            jiefu Jie Fu
            Reporter:
            jiefu Jie Fu
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: