Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8231472

Clean up Monitor::_safepoint_check usage to Mutex::_safepoint_check

    XMLWordPrintable

    Details

    • Type: Enhancement
    • Status: Resolved
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 14
    • Component/s: hotspot
    • Labels:
      None
    • Subcomponent:
    • Resolved In Build:
      b17

      Description

      From code review comments from [~rehn]: First, a side note, I notice that we forgot to change, e.g.:
      Monitor::_safepoint_check_never to Mutex::_safepoint_check_never in some places.

      I'd left Monitor::_safepoint_check_never in places where the code had new Monitor(etc, Monitor::_safepoint_check_never); ie. the code was initializing a Monitor. But there are some left over from allocating a Mutex. The code for mutexLocker.cpp that initializes the mutex/monitors doesn't need to specify Monitor::_safepoint_check_{never,sometimes,always}. It can be done in the macro.

        Attachments

          Activity

            People

            Assignee:
            coleenp Coleen Phillimore
            Reporter:
            coleenp Coleen Phillimore
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: