Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8231862

Decouple DesktopIntegration and LinuxPackageBundler classes

    XMLWordPrintable

    Details

    • Type: Enhancement
    • Status: Resolved
    • Priority: P3
    • Resolution: Fixed
    • Affects Version/s: internal
    • Fix Version/s: internal
    • Component/s: tools
    • Labels:
    • Subcomponent:
    • CPU:
      generic
    • OS:
      generic

      Description

      DesktopIntegration class is inner in LinuxPackageBundler.
      Just because it depends on LinuxPackageBundler.fetchResource(). It would be good to have these classes separated.

      fetchResource() is declared in AbstractBundler class. Similar functionality is provided by AbstractAppImageBuilder.locateResource().

      AbstractAppImageBuilder.preprocessTextResource() is a copy/paste of AbstractBundler.preprocessTextResource() or vice versa that both provide similar functionality to fetchResource() plus text substitution.

      Move preprocessTextResource() and fetchResource() to a separate class that can be used by bundler classes and by DesktopIntegration class. This would eliminate code duplication between AbstractBundler and AbstractAppImageBuilder classes and allow to decouple DesktopIntegration and LinuxPackageBundler classes.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              asemenyuk Alexey Semenyuk
              Reporter:
              asemenyuk Alexey Semenyuk
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: