Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8233303

Shenandoah: verifier assert erroneously uses byte_size_in_exact_unit

    Details

    • Subcomponent:
      gc
    • Resolved In Build:
      b22

      Description

      Typo in JDK-8232102 found by sh/jdk8 backports, where byte_size_in_exact_unit is not defined. Should actually be "proper_unit":

      diff -r b026a43e1809 src/hotspot/share/gc/shenandoah/shenandoahVerifier.cpp
      --- a/src/hotspot/share/gc/shenandoah/shenandoahVerifier.cpp Tue Oct 29 09:34:23 2019 +0800
      +++ b/src/hotspot/share/gc/shenandoah/shenandoahVerifier.cpp Thu Oct 31 10:08:22 2019 +0100
      @@ -693,12 +693,12 @@
       
           size_t heap_committed = _heap->committed();
           guarantee(cl.committed() == heap_committed,
                     "%s: heap committed size must be consistent: heap-committed = " SIZE_FORMAT "%s, regions-committed = " SIZE_FORMAT "%s",
                     label,
      - byte_size_in_exact_unit(heap_committed), proper_unit_for_byte_size(heap_committed),
      - byte_size_in_exact_unit(cl.committed()), proper_unit_for_byte_size(cl.committed()));
      + byte_size_in_proper_unit(heap_committed), proper_unit_for_byte_size(heap_committed),
      + byte_size_in_proper_unit(cl.committed()), proper_unit_for_byte_size(cl.committed()));
         }
       
         // Internal heap region checks
         if (ShenandoahVerifyLevel >= 1) {
           ShenandoahVerifyHeapRegionClosure cl(label, regions);

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                shade Aleksey Shipilev
                Reporter:
                shade Aleksey Shipilev
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: