Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8233574

Shenandoah: build is broken without jfr

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: 8-shenandoah, 11-shenandoah, 13, 14
    • Fix Version/s: 14
    • Component/s: hotspot
    • Subcomponent:
      gc
    • Resolved In Build:
      b22

      Description

      * Reproduce
      -------------------------------------
      bash ${JDK}/configure --with-debug-level=fastdebug --with-jvm-features=-jfr
      make CONF=fastdebug images
      -------------------------------------

      * Symptom
      -------------------------------------
      * For target hotspot_variant-server_libjvm_objs_shenandoahRootProcessor.o:
      In file included from /home/fool/workspace/jdk-dev/src/hotspot/share/gc/shenandoah/shenandoahHeuristics.hpp:27:0,
                       from /home/fool/workspace/jdk-dev/src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.inline.hpp:31,
                       from /home/fool/workspace/jdk-dev/src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.cpp:30:
      /home/fool/workspace/jdk-dev/src/hotspot/share/gc/shenandoah/shenandoahHeap.hpp:297:15: error: inline function 'bool ShenandoahHeap::is_full_gc_in_progress() const' used but never defined [-Werror]
         inline bool is_full_gc_in_progress() const;
                     ^~~~~~~~~~~~~~~~~~~~~~
      -------------------------------------

      * Fix
      -------------------------------------
      diff -r c41d1303a87c src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.cpp
      --- a/src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.cpp Mon Nov 04 13:02:40 2019 -0800
      +++ b/src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.cpp Tue Nov 05 10:03:34 2019 +0800
      @@ -29,6 +29,7 @@
       #include "code/codeCache.hpp"
       #include "gc/shenandoah/shenandoahRootProcessor.inline.hpp"
       #include "gc/shenandoah/shenandoahHeap.hpp"
      +#include "gc/shenandoah/shenandoahHeap.inline.hpp"
       #include "gc/shenandoah/shenandoahPhaseTimings.hpp"
       #include "gc/shenandoah/shenandoahStringDedup.hpp"
       #include "gc/shenandoah/shenandoahTimingTracker.hpp"
      -------------------------------------

        Attachments

          Activity

            People

            • Assignee:
              jiefu Jie Fu
              Reporter:
              jiefu Jie Fu
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: