Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8238249

GetPrimitiveArrayCritical passed with hardcoded FALSE value

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: P3
    • Resolution: Fixed
    • Affects Version/s: 8, openjfx11
    • Fix Version/s: openjfx15
    • Component/s: javafx
    • Labels:

      Backports

        Description

        The following call to GetPrimitiveArrayCritical in jpegloader.c is misleading:

                   jboolean iscopy = FALSE;
                    jbyte *body = (*env)->GetPrimitiveArrayCritical(env, barray, &iscopy);

        It looks like we want to pass "FALSE" to the isCopy parameter of GetPrimitiveArrayCritical, while this field is actually set by the VM when it informs the caller whether a copy is made or not. The jscopy parameter is not used outside this scope.

          Attachments

            Issue Links

              Activity

                People

                Assignee:
                jvos Johan Vos
                Reporter:
                jvos Johan Vos
                Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                  Dates

                  Created:
                  Updated:
                  Resolved: