Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8240231

Build failure on illumos after 8238988

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: 15
    • Fix Version/s: 15
    • Component/s: hotspot
    • Labels:
      None
    • Subcomponent:
    • Resolved In Build:
      b13
    • CPU:
      x86_64
    • OS:
      solaris

      Description

      On 2/28/20 8:16 AM, Peter Tribble wrote:
      > Hi,
      >
      > I'm building from source on illumos. After
      >
      > 8238988: Rename thread "in stack" methods and add in_stack_range
      >
      > I get a build failure:
      >
      > "/export/home/ptribble/ud/jdk-jdk-15+12/src/hotspot/os_cpu/solaris_x86/thread_solaris_x86.cpp",
      > line 92: Error: Formal argument limit of type unsigned char* in call to
      > Thread::is_in_stack_range_incl(unsigned char*, unsigned char*) const is
      > being passed long*.
      > 1 Error(s) detected.
      >
      > Looking at line 92 of src/hotspot/os_cpu/solaris_x86/thread_solaris_x86.cpp:
      >
      > if (!jt->is_in_stack_range_incl((address)ret_fp, ret_sp)) {
      >
      > shouldn't the 2nd argument also be cast, as the signature has both being
      > the same type? Like so:
      >
      > if (!jt->is_in_stack_range_incl((address)ret_fp, (address)ret_sp)) {
      >
      > with that change, I get a clean build again, and a working jdk.
      >
      > Thanks,
      >

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              dcubed Daniel Daugherty
              Reporter:
              dcubed Daniel Daugherty
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: