Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8241067

Shenandoah: improve ShenandoahNMethod::has_cset_oops arguments

    Details

    • Subcomponent:
      gc
    • Resolved In Build:
      b16

      Description

      Static analyzers say heap argument is unused here:

      bool ShenandoahNMethod::has_cset_oops(ShenandoahHeap *heap) {
        ShenandoahHasCSetOopClosure cl;
        oops_do(&cl);
        return cl.has_cset_oops();
      }

      ShenandoahHasCSetOopClosure gets the heap in its own constructor. Either we should drop the parameter from SHNM::has_cset_oops, or we should pass it to ShenandoahHasCSetOopClosure, depending on which produces the better code.

        Attachments

          Activity

            People

            • Assignee:
              adityam Aditya Mandaleeka
              Reporter:
              shade Aleksey Shipilev
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: