Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8241122

Remove unimplemented InlineTree constructor definition from parse.hpp

    XMLWordPrintable

    Details

    • Type: Enhancement
    • Status: Resolved
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: 11, 14, 15
    • Fix Version/s: 15
    • Component/s: hotspot
    • Labels:
    • Subcomponent:
    • Resolved In Build:
      b15

      Description

      On 3/17/20 12:43 PM, Charlie Gracie wrote:
      When looking through the code for InlineTree I noticed an unimplemented constructor definition. I spent a few mins looking for the
      implementation and it's uses so I figure it is best to get it removed so others do not spend time as well.

      I tested compilation of release, fastdebug and slowdebug builds on my Mac and also verified the JVM still starts.

      Here is the patch for tip:
      diff --git a/src/hotspot/share/opto/parse.hpp b/src/hotspot/share/opto/parse.hpp
      index 28e440f586..adbb5ba355 100644
      --- a/src/hotspot/share/opto/parse.hpp
      +++ b/src/hotspot/share/opto/parse.hpp
      @@ -107,9 +107,6 @@ public:
         static InlineTree* build_inline_tree_root();
         static InlineTree* find_subtree_from_root(InlineTree* root, JVMState* jvms, ciMethod* callee);
       
      - // For temporary (stack-allocated, stateless) ilts:
      - InlineTree(Compile* c, ciMethod* callee_method, JVMState* caller_jvms, float site_invoke_ratio, int max_inline_level);
      -
         // See if it is OK to inline.
         // The receiver is the inline tree for the caller.
         //

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              kvn Vladimir Kozlov
              Reporter:
              kvn Vladimir Kozlov
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: