Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8243059

Build fails when --with-vendor-name contains a comma

    Details

    • Subcomponent:
    • Resolved In Build:
      b20
    • CPU:
      generic
    • OS:
      generic

      Backports

        Description

        When attempting a build like so:

        $ configure [....] --with-vendor-name="THL A29 Limited, a Tencent company" [...]

        $ make images

        It fails with:

        gmake[2]: *** [make/Main.gmk:221: java.base-launchers] Error 2
        gmake[2]: *** Waiting for unfinished jobs....
        gmake[3]: Entering directory '/disk/openjdk/upstream-sources/openjdk-head/make'

        Looking closer one notices this for SetupJdkExecutable BUILD_LAUNCHER_java:

        SetupJdkExecutable BUILD_LAUNCHER_java
         [2] NAME := java
         [3] EXTRA_FILES := /disk/openjdk/upstream-sources/openjdk-head/src/java.base/share/native/launcher/main.c
         [4] OPTIMIZATION := HIGH
         [5] CFLAGS := -I/disk/openjdk/upstream-sources/openjdk-head/build/linux-x86_64-server-release/support/modules_include/java.base -I/disk/openjdk/upstream-sources/openjdk-head/build/linux-x86_64-server-release/support/modules_include/java.base/linux -I/disk/openjdk/upstream-sources/openjdk-head/src/java.base/share/native/libjava -I/disk/openjdk/upstream-sources/openjdk-head/src/java.base/unix/native/libjava -I/disk/openjdk/upstream-sources/openjdk-head/src/hotspot/share/include -I/disk/openjdk/upstream-sources/openjdk-head/src/hotspot/os/posix/include -pipe -fstack-protector -D_GNU_SOURCE -D_REENTRANT -D_LARGEFILE64_SOURCE -DLINUX -DNDEBUG -fmacro-prefix-map=/disk/openjdk/upstream-sources/openjdk-head/= -std=c99 -fno-strict-aliasing -Wall -Wextra ...
         [6] a Tencent company"' -DVENDOR_URL='"https://openjdk.java.net/"' -DVENDOR_URL_BUG='"https://bugreport.java.com/bugreport/"' -DVENDOR_URL_VM_BUG='"https://bugreport.java.com/bugreport/crash.jsp"' -DLAUNCHER_NAME='"openjdk"' -DPROGNAME='"java"' -DEXPAND_CLASSPATH_WILDCARDS -DENABLE_ARG_FILES -DJAVA_ARGS='{ "-J-ms8m", }'
         [7] CFLAGS_solaris := -KPIC

        Note that parameter '[6]' is bogus:
         [6] a Tencent company"' -DVENDOR_URL='"https://openjdk.java.net/"' -DVENDOR_URL_BUG='"https://bugreport.java.com/bugreport/"' -DVENDOR_URL_VM_BUG='"https://bugreport.java.com/bugreport/crash.jsp"' -DLAUNCHER_NAME='"openjdk"' -DPROGNAME='"java"' -DEXPAND_CLASSPATH_WILDCARDS -DENABLE_ARG_FILES -DJAVA_ARGS='{ "-J-ms8m", }'

        The comma got expanded and interpreted as a parameter separator!

          Attachments

            Issue Links

              Activity

                People

                • Assignee:
                  sgehwolf Severin Gehwolf
                  Reporter:
                  sgehwolf Severin Gehwolf
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: