Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8245035

Clean up os::split_reserved_memory()

    Details

    • Type: Enhancement
    • Status: Resolved
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: 15
    • Fix Version/s: 15
    • Component/s: hotspot
    • Subcomponent:
    • Resolved In Build:
      b24

      Description

      os::split_reserved_memory() should be cleaned up a bit.

      It is used to split reserved memory regions in order to make them independent units. This only matters when releasing them, so after splitting these regions should be releasable independently from each other.

      This only matters on Windows, which is the only platform with a non-empty implementation, since virtual memory can only be released as a unit (opposed to mmap api, where sub regions can be unmapped individually).

      Improvements:
      - the interface should be commented
      - the "realloc" parameter can be removed. It has never not been true on all code paths - had it been, it would have been an error on windows resulting in loosing one of the two sides of the split.
      - the many non-windows implementations can be combined in posix.cpp.


        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                stuefe Thomas Stuefe
                Reporter:
                stuefe Thomas Stuefe
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: