Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8245831

Unify code parsing version strings on Mac and Windows

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: P3
    • Resolution: Fixed
    • Affects Version/s: 15
    • Fix Version/s: 15
    • Component/s: tools
    • Labels:
    • Subcomponent:
    • Resolved In Build:
      b26
    • OS:
      generic

      Description

      MacAppBundler.validCFBundleVersion() and MacAppImageBuilder.validCFBundleVersion() functions are duplicates.
      MacAppBundler.validCFBundleVersion() and WinMsiBundler.isVersionStringValid() functions duplicate functionality of DottedVersion class that parses dot separated version strings.

      It is better to move functionality of MacAppBundler.validCFBundleVersion() and WinMsiBundler.isVersionStringValid() functions to separate classes with unit test coverage. Implementation of these classes should be based on DottedVersion class.

        Attachments

          Activity

            People

            • Assignee:
              asemenyuk Alexey Semenyuk
              Reporter:
              asemenyuk Alexey Semenyuk
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: