Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8247831

Clamp texture height to maxTextureSize(16384)

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: internal
    • Fix Version/s: internal
    • Component/s: client-libs
    • Labels:
    • Subcomponent:
      2d
    • CPU:
      x86_64
    • OS:
      os_x

      Description

      In addition to what has been done as part of JDK-8247772 fix, I have below review comments -
      1) Need to check the same maxTextureSize condition for texture height as well.
      2) Need to add a log message to help detect the clamping while debugging.

      Also, I think, currently the tests that request texture with large dimensions do not check for whether they get textures with dimensions clamped to max platform supported value. (true for all rendering pipelines)
      We need to think about what to do with such tests? May be add an assertion such that it is expected to have clamped dimensions.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                psadhukhan Prasanta Sadhukhan
                Reporter:
                aghaisas Ajit Ghaisas
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: