Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8249777

build.gradle: project.version should not contain time stamps

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: P3
    • Resolution: Fixed
    • Affects Version/s: openjfx11, openjfx16
    • Fix Version/s: openjfx16
    • Component/s: javafx
    • Labels:

      Description

      The addMavenPublication method sets the project.version to $MAVEN_VERSION. When doing an ordinary "developer" build, this property contains the time stamp . The setting of project.version is only used by the maven "publish" tasks, which isn't done for developer builds (other than when testing it).

      This is causing problems with the NetBeans gradle plugin not being able to determine the dependencies between the projects if the generation and the query of the dependencies are done at different times. See:

      https://mail.openjdk.java.net/pipermail/openjfx-dev/2020-July/027078.html

      We haven't noticed this before now, because we suppress the creation of the individual project jar files, but if we were creating them, we would have the problem that each time we ran gradle, it would generate a new project-$version.jar file with a different time stamp.

      We need to remove the time stamp from the MAVEN_VERSION by default. If for some reason it is needed for testing, we can add a property to enable it. I suspect it won't be, but Johan and Joeri should comment. Note that this won't affect any released artifacts, including EA builds, that are uploaded to maven central, since they are done using release builds (CONF=Release and HUDSON_JOB_NAME, HUDSON_BUILD_NUMBER, and PROMOTED_BUILD_NUMBER are all set).

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                kcr Kevin Rushforth
                Reporter:
                kcr Kevin Rushforth
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: