Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8249940

Remove unnecessary includes of jni_util.h in native tests

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: 16
    • Fix Version/s: 16
    • Component/s: hotspot
    • Labels:
      None
    • Subcomponent:
    • Resolved In Build:
      b08

      Description

      A number of native tests in hotspot and jdk include the jni_util.h header file which is part of the sources for libjava and not part of the testing framework, nor an exported interface for the JDK. This seems to have occurred through copy-and-paste when creating the tests as the include is not needed.

      test/hotspot/jtreg/runtime/jni/FindClass/libbootLoaderTest.c
      test/hotspot/jtreg/runtime/jni/registerNativesWarning/libregisterNativesWarning.c
      test/hotspot/jtreg/runtime/jni/terminatedThread/libterminatedThread.c
      test/jdk/java/lang/ClassLoader/nativeLibrary/libnativeLibraryTest.c
      test/jdk/java/lang/ProcessBuilder/checkHandles/libCheckHandles.c
      test/jdk/jdk/internal/loader/NativeLibraries/libnativeLibrariesTest.c

      There is one test that includes jni_util.h and uses the utility function declared there:
      ./jdk/java/lang/String/nativeEncoding/libstringPlatformChars.c
      so that is left as-is.

        Attachments

          Activity

            People

            • Assignee:
              dholmes David Holmes
              Reporter:
              dholmes David Holmes
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: