Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8250586

jarsigner refactoring in displayMessagesAndResult() method

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 16
    • Component/s: security-libs
    • Labels:

      Description

      There are two multiple-level if blocks in displayMessagesAndResult() method where checking of various jarsigner flags are done. They should be refactored to keep the inner checks so we won’t check a flag multiple times. The outer checks should be removed. This is to make checking of each flag independent, and to make the code cleaner.

      The checking of ‘hasExpiredTsaCert' flag needs to be consolidated and is checked against with ‘signerNotExpired' flag in order to issue adequate messages.

        Attachments

          Activity

            People

            Assignee:
            hchao Haimay Chao
            Reporter:
            hchao Haimay Chao
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: