Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8251358

Clean up Access configuration after Shenandoah barrier change

    XMLWordPrintable

    Details

    • Type: Enhancement
    • Status: Resolved
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: 11, 16
    • Fix Version/s: 16
    • Component/s: hotspot
    • Subcomponent:
      gc
    • Resolved In Build:
      b18

      Description

      Shenandoah changed their barriers to no longer break the to-space invariant, and to no longer need barriers on primitives.

      As a result, the "SUPPORT" macros in barrierSetConfig.hpp (SUPPORT_BARRIER_ON_PRIMITIVES and SUPPORT_NOT_TO_SPACE_INVARIANT) are never set. So the conditionalization on them can be removed.

      A a result, INTERNAL_BT_BARRIER_ON_PRIMITIVES can always be assumed clear and INTERNAL_BT_TO_SPACE_INVARIANT can always be assumed set. So the (small number) of places examining them can be hard-coded and those decorators can be removed.

      The Access::resolve function should also no longer be needed; callers can be cleaned up and it can be removed.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              adityam Aditya Mandaleeka
              Reporter:
              kbarrett Kim Barrett
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: