Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8251543

add mention of INFLATING() to share/oops/markWord.hpp header comment

    XMLWordPrintable

    Details

    • Type: Enhancement
    • Status: Resolved
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: 16
    • Fix Version/s: 16
    • Component/s: hotspot
    • Labels:
      None
    • Subcomponent:
    • Resolved In Build:
      b12
    • CPU:
      generic
    • OS:
      generic

      Description

      David H. noticed that the header comment in
      src/hotspot/share/oops/markWord.hpp that discusses
      the markWord encoding does not mention the
      special INFLATING value.

      Here's a proposal:

      $ hg diff
      diff -r 73778bfbffe3 src/hotspot/share/oops/markWord.hpp
      --- a/src/hotspot/share/oops/markWord.hpp Thu Aug 13 10:02:35 2020 -0400
      +++ b/src/hotspot/share/oops/markWord.hpp Thu Aug 13 10:51:44 2020 -0400
      @@ -86,6 +86,10 @@
       // [ptr | 11] marked used to mark an object
       //
       // We assume that stack/thread pointers have the lowest two bits cleared.
      +//
      +// - INFLATING() is a distinguished markword value that is used when
      +// inflating an existing stack lock into an ObjectMonitor. See below
      +// for is_being_inflated() and INFLATING().
       
       class BasicLock;
       class ObjectMonitor;
      @@ -226,7 +230,7 @@
         bool is_being_inflated() const { return (value() == 0); }
       
         // Distinguished markword value - used when inflating over
      - // an existing stacklock. 0 indicates the markword is "BUSY".
      + // an existing stack lock. 0 indicates the markword is "BUSY".
         // Lockword mutators that use a LD...CAS idiom should always
         // check for and avoid overwriting a 0 value installed by some
         // other thread. (They should spin or block instead. The 0 value

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              dcubed Daniel Daugherty
              Reporter:
              dcubed Daniel Daugherty
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: