Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8252237

C2: Call to compute_separating_interferences has wrong argument order

    XMLWordPrintable

    Details

    • Subcomponent:
    • Resolved In Build:
      b21

      Description

      CLion static analyzer highlights this oddity.

      PhaseConservativeCoalesce::copy_copy calls compute_separating_interferences with [breaking the lines to make the grouping clear]:

      reg_degree = compute_separating_interferences(
      dst_copy, src_copy,
      b, bindex,
      rm,
      rm_size, reg_degree, // <--- look here
      lr1, lr2
      );

      ...yet the definition is [again, breaking the lines]:

      uint PhaseConservativeCoalesce::compute_separating_interferences(
      Node *dst_copy, Node *src_copy,
      Block *b, uint bindex,
      RegMask &rm,
      uint reg_degree, uint rm_size, // <--- different order
      uint lr1, uint lr2
      ) {

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              rraghavan Rahul Raghavan
              Reporter:
              shade Aleksey Shipilev
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: