Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8252966

CI: Remove KILL_COMPILE_ON_FATAL_ and KILL_COMPILE_ON_ANY macros

    Details

    • Type: Enhancement
    • Status: Resolved
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: 16
    • Fix Version/s: 16
    • Component/s: hotspot
    • Labels:
    • Subcomponent:
    • Resolved In Build:
      b16

      Description

      Replace KILL_COMPILE_ON_FATAL_ with CHECK_AND_CLEAR_.

      KILL_COMPILE_ON_FATAL_ checks for ThreadDeath, but compiler threads shouldn't receive it.

      src/hotspot/share/ci/ciUtilities.inline.hpp:

          69 // Redefine this later.
          70 #define KILL_COMPILE_ON_FATAL_(result) \
          71 THREAD); \
          72 if (HAS_PENDING_EXCEPTION) { \
          73 if (PENDING_EXCEPTION->klass() == \
          74 SystemDictionary::ThreadDeath_klass()) { \
          75 /* Kill the compilation. */ \
          76 fatal("unhandled ci exception"); \
          77 return (result); \
          78 } \
          79 CLEAR_PENDING_EXCEPTION; \
          80 return (result); \
          81 } \
          82 (void)(0


      KILL_COMPILE_ON_ANY is not unused and can be removed right away:

          84 #define KILL_COMPILE_ON_ANY \
          85 THREAD); \
          86 if (HAS_PENDING_EXCEPTION) { \
          87 fatal("unhandled ci exception"); \
          88 CLEAR_PENDING_EXCEPTION; \
          89 } \
          90 (void)(0

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                rcastanedalo Roberto Castaneda Lozano
                Reporter:
                vlivanov Vladimir Ivanov
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: