Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8254285

G1: Remove "What is this about" comment in G1CollectedHeap.cpp

    XMLWordPrintable

    Details

    • Type: Enhancement
    • Status: Resolved
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: 16
    • Fix Version/s: 16
    • Component/s: hotspot
    • Subcomponent:
      gc
    • Resolved In Build:
      b20

      Description

      In g1CollectedHeap.cpp there is this comment:

        // FIXME: what is this about?
        // I'm ignoring the "fill_newgen()" call if "alloc_event_enabled"
        // is set.

      that does not make sense at all as the FIXME indicates. This comment has been introduced with the open sourcing of G1 (JDK-6711316).

      Fill_newgen() has as far as I could gather some method used in Serial GC that has been removed long ago too.

      Let's remove this comment.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              tschatzl Thomas Schatzl
              Reporter:
              tschatzl Thomas Schatzl
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: